Rollup of 6 pull requests #72501
Closed
Rollup of 6 pull requests #72501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#72386 This type also needs to get allocated on the `librustc_middle` arena when we deserialize MIR.
…tead of `NodeId`
Add missing ASM arena declarations to librustc_middle Fixes rust-lang#72386 These types also need to get allocated on the `librustc_middle` arena when we deserialize MIR. @Amanieu: If we end up using your approach in rust-lang#72392 instead, feel free to copy the test I added over to your PR.
…, r=ecstatic-morse Remove all uses of `NodeId` in `ResolverOutputs` cc rust-lang#50928 r? @ecstatic-morse
add warning sign to UB examples Just to make it less likely that people miss the fact that these are examples for how to *not* do it.
Impl Ord for proc_macro::LineColumn
```rust
impl Ord for LineColumn {...}
impl PartialOrd for LineColumn {...}
```
for https://doc.rust-lang.org/nightly/proc_macro/struct.LineColumn.html.
The ordering is the natural one you would get by writing one line after another, where we compare line first, then compare columns within the same line.
Add some regression tests Closes rust-lang#69415 Closes rust-lang#72455 r? @matthewjasper
Correct small typo: 'not' -> 'note'
|
@bors r+ rollup=never p=6 |
|
📌 Commit ea3aca4 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit ea3aca4 with merge f07d401787a9122857f86f23cbf753edca059589... |
bors
added
S-waiting-on-author
bors
added
S-waiting-on-bors
|
rerolling in a minute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
NodeIdinResolverOutputs#72402 (Remove all uses ofNodeIdinResolverOutputs)Failed merges:
r? @ghost