ClosureSubsts/GeneratorSubsts refactoring #72633
Conversation
Now stored directly instead of requiring a cast. As a result as_closure/as_generator casts are removed. This change allows to encapsulate synthetic generic args handling inside of ClosureSbusts/GeneratorSubsts instead of leaking implementation details in SubstsRef.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Elinvynia
added
S-waiting-on-review
|
Ping from triage: |
|
@eddyb I really don't want to waste time rebasing this change unless there is interest in it. |
JohnCSimon
added
S-waiting-on-author
|
@VFLashM Sorry, I didn't see this PR, you should've coordinated with @nikomatsakis. I believe as-is it's reverting a past change, which was probably done with Chalk integration in mind, but I don't know the details. |
|
Yeah, it is reverting a change that was made with the intent of moving towards a chalk-like setup. Specifically, the goal was that we could group all "nominal-like types" into a setup that combines a (id, substs) pair (i.e., closures, generators, ADTs, even things like booleans and tuples, can all be described in this uniform way). The chalk book explains. I'm inclined to close this PR, but one of the things that I'm hoping to do now that I'm back from vacation is laying out a series of steps to complete and explore the transition to chalk-like types, and in particular complete the work towards a shared type library (see rust-lang/types-team#16 for current info, it needs some updating though). @VFLashM I wonder if you'd be interested in participating in that effort? |
|
I see. Thanks for the details. No problem, let's close it then. I don't think I'll have enough time to work on such a major effort anytime soon, sorry. |
Now stored directly instead of requiring a cast.
As a result
as_closure/as_generatorcasts are removed.This change allows to encapsulate synthetic generic args handling inside of
ClosureSbusts/GeneratorSubstsinstead of leaking implementation details inSubstsRef.Didn't expect this change to blow up this big. Please let me know if there is interest in this change before I start rebasing it.