Skip to content

fix MIR validation around impl Trait #75399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix MIR validation around impl Trait #75399

wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

Fixes #75313

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2020
@RalfJung
Copy link
Member Author

Argh... the test doesn't actually test the problem. :/ It passes even when I change nothing. Wtf.

@RalfJung
Copy link
Member Author

It needs to be "build-pass" to check anything.

@RalfJung
Copy link
Member Author

I think I'll never use check-pass again as I have no way to predict if it will actually test for the right problem... I am pretty worried right now about all those check-pass tests in our test suite.^^

@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2020

check builds don't run the mir_optimized query. Which is good for getting a fast cargo check, but bad because we're missing const prop and similar. So yea, check-pass doesn't run any mir optimizations

@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2020

Maybe we should change check-pass so it actually runs the optimizations, even if cargo check won't?

@RalfJung
Copy link
Member Author

Dunno, that also seems surprising.

@RalfJung
Copy link
Member Author

Yeah, reveal_all is not sufficient to fix the problem. :(

@RalfJung
Copy link
Member Author

Using a type folder doesn't work either. No idea how to fix this, sorry.

@RalfJung RalfJung closed this Aug 11, 2020
@RalfJung RalfJung deleted the mir-validate-impl-trait branch August 11, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when compiling gluon on 1.46
3 participants
@RalfJung @rust-highfive @oli-obk