Check for comparisons to NaN in patterns #8029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For every pattern that refers to a static value, evaluate it and emit a warning if it is a NaN. Fixes rust-lang#6804
|
@cmr Thanks. I fixed the warning message. |
bors
added a commit
that referenced
this pull request
Jul 25, 2013
Hi, As noted in #6804, a pattern that contains `NaN` will never match because `NaN != NaN`. This adds a warning for such a case. The first commit handles the basic case and the second one generalizes it to more complex patterns using `walk_pat`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…_structs-OnNonExhaustive, r=Manishearth Do not trigger ``[`rest_pat_in_fully_bound_structs`]`` on `#[non_exhaustive]` structs fixes rust-lang#8029 Just adds an additional check to ensure that the`ty::VariantDef` is not marked as `#[non_exhaustive]`. changelog: Do not apply ``[`rest_pat_in_fully_bound_structs`]`` on structs marked as non exhaustive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As noted in #6804, a pattern that contains
NaNwill never match becauseNaN != NaN. This adds a warning for such a case. The first commit handles the basic case and the second one generalizes it to more complex patterns usingwalk_pat.