librust: Stop rust tool from crashing on macos. #8086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely doesn't close 7617, so could you put a FIXME above that line attributing it to the issue? Also if you found anything which is useful to write in as well, I'm sure a future-someone would thank you immensely! |
|
@alexcrichton if this doesn't close #7617, could you edit the title of that issue to make it more clear. Since to me, this does close that issue. |
|
Indeed I can! |
bors
added a commit
that referenced
this pull request
Jul 28, 2013
#7617 While the code that was there should've been perfectly fine (and seemingly is on linux at least) there seems to be some sort of weird interaction going on with statics and vectors. I couldn't get a smaller test case to reproduce that behaviour. The for loop in `rust::usage` seemingly just goes past the end of the vector thus getting garbage which it tries to pass to malloc somewhere down the line. In any case, using a fixed length vector seems to mitigate this.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2021
Fix bad suggestion on `option_if_let_else` when there is complex subpat closes rust-lang#7991 Prefer not warning any complex subpat in `option_if_let_else` rather than suggesting obscure suggestions. changelog: [`option_if_let_else`] does not warn when complex subpat is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7617
While the code that was there should've been perfectly fine (and seemingly is on linux at least) there seems to be some sort of weird interaction going on with statics and vectors. I couldn't get a smaller test case to reproduce that behaviour. The for loop in
rust::usageseemingly just goes past the end of the vector thus getting garbage which it tries to pass to malloc somewhere down the line.In any case, using a fixed length vector seems to mitigate this.