Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tmiasko and others added 14 commits January 15, 2021 00:00
It had exactly one field and no special behavior, so there was no point.
There's no `Variant`, so it seems silly to have `Kind`.
Add test for rust-lang#59352

Issue rust-lang#59352 reported an optimization regression with rustc 1.32.0+. That regression could be tracked to a change that caused a function to miss the size limit of llvm's inlining, which results in an unreachable panicing branch being generated.
Enabling mir inline solves the issue, but is currently only done for `mir-opt-level>=2`.

This PR adds a test that can serve as a regression test for rust-lang#59352, if/when mir inlining gets mature enough for opt-level 1, or some other optimization can remove the panic.
…Nemo157,jyn514

Improve JS performance by storing length before comparing to it in loops

Since rust-lang#79052 is quite complicated to review, I suggested to split into smaller parts. This first part is mostly about saving the array length into a variable (I tried to not change anything else as much as possible 😃 ).

r? `@jyn514`
Remove useless `clean::Variant` struct

It had exactly one field and no special behavior, so there was no point in having it.

r? `@CraftSpider`
inline: Round word-size cost estimates up
Drop a few unneeded borrows

`@rustbot` modify labels +C-cleanup +T-compiler
@rustbot rustbot added the rollup A PR which is a rollup label Jan 15, 2021
@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=6

@bors
Copy link
Collaborator

bors commented Jan 15, 2021

📌 Commit f8b1baa has been approved by GuillaumeGomez

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 15, 2021
@bors
Copy link
Collaborator

bors commented Jan 16, 2021

⌛ Testing commit f8b1baa with merge 6c869d3...

@bors
Copy link
Collaborator

bors commented Jan 16, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 6c869d3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 16, 2021
@bors bors merged commit 6c869d3 into rust-lang:master Jan 16, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 16, 2021
@bors bors mentioned this pull request Jan 16, 2021
@GuillaumeGomez GuillaumeGomez deleted the rollup-yl2kqst branch January 16, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants