Fix formatting for removed lints #81135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
A-lints
rust-highfive
added
the
S-waiting-on-review
|
err I'm not sure if you have r? permissions - here they are just in case: @bors delegate=flip1995 |
|
✌️ @flip1995 can now approve this pull request |
This comment has been minimized.
This comment has been minimized.
- Don't add backticks for the reason a lint was removed. This is almost never a code block, and when it is the backticks should be in the reason itself. - Don't assume clippy is the only tool that needs to be checked for backwards compatibility
|
Clippy also has tests for this in I don't have r+ rights here, but I generally approve this change. Always wondered why those backticks were there. |
|
@bors r=flip1995 |
|
📌 Commit 77b5ced has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 20, 2021
Fix formatting for removed lints - Don't add backticks for the reason a lint was removed. This is almost never a code block, and when it is the backticks should be in the reason itself. - Don't assume clippy is the only tool that needs to be checked for backwards compatibility I split this out of rust-lang#80527 because it kept causing tests to fail, and it's a good change to have anyway. r? `@flip1995`
|
⌛ Testing commit 77b5ced with merge 894f85d1d45998a3413d0bd0faca3cea02d099da... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 30, 2021
Fix formatting for removed lints - Don't add backticks for the reason a lint was removed. This is almost never a code block, and when it is the backticks should be in the reason itself. - Don't assume clippy is the only tool that needs to be checked for backwards compatibility I split this out of rust-lang#80527 because it kept causing tests to fail, and it's a good change to have anyway. r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never a code block, and when it is the backticks should be in the reason
itself.
backwards compatibility
I split this out of #80527 because it kept causing tests to fail, and it's a good change to have anyway.
r? @flip1995