Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 21, 2021

The idea is to help me find out where the time is being spent in compiling the docs for windows-rs: microsoft/windows-rs#420 (comment)

@jyn514 jyn514 added A-resolve Area: Name/path resolution done by `rustc_resolve` specifically T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-self-profile Area: Self-profiling feature of the compiler labels Jan 21, 2021
@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jan 21, 2021

Hmm, it looks like this removed resolve_crate from the output for some reason?

time: 0.000; rss: 221MB	maybe_create_a_macro_crate
time: 0.012; rss: 222MB	finalize_imports
time: 0.015; rss: 222MB	finalize_macro_resolutions
time: 0.160; rss: 257MB	late_resolve_crate
time: 0.007; rss: 257MB	resolve_check_unused
time: 0.000; rss: 257MB	resolve_report_errors
time: 0.006; rss: 257MB	resolve_postprocess
time: 0.012; rss: 257MB	complete_gated_feature_checking

@jyn514
Copy link
Member Author

jyn514 commented Jan 21, 2021

Ok, should be fixed.

time: 0.012; rss: 422MB	finalize_imports
time: 0.038; rss: 424MB	finalize_macro_resolutions
time: 0.307; rss: 459MB	late_resolve_crate
time: 0.009; rss: 459MB	resolve_check_unused
time: 0.000; rss: 459MB	resolve_report_errors
time: 0.008; rss: 459MB	resolve_postprocess
time: 0.374; rss: 459MB	resolve_crate

@jyn514
Copy link
Member Author

jyn514 commented Jan 21, 2021

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned varkor Jan 21, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 21, 2021

📌 Commit 5f74ab4 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2021
…as-schievink

Rollup of 15 pull requests

Successful merges:

 - rust-lang#79841 (More clear documentation for NonNull<T>)
 - rust-lang#81072 (PlaceRef::ty: use method call syntax)
 - rust-lang#81130 (Edit rustc_middle::dep_graph module documentation)
 - rust-lang#81170 (Avoid hash_slice in VecDeque's Hash implementation)
 - rust-lang#81243 (mir: Improve size_of handling when arg is unsized)
 - rust-lang#81245 (Update cargo)
 - rust-lang#81249 (Lower closure prototype after its body.)
 - rust-lang#81252 (Add more self-profile info to rustc_resolve)
 - rust-lang#81275 (Fix <unknown> queries and add more timing info to render_html)
 - rust-lang#81281 (Inline methods of Path and OsString)
 - rust-lang#81283 (Note library tracking issue template in tracking issue template.)
 - rust-lang#81285 (Remove special casing of rustdoc in rustc_lint)
 - rust-lang#81288 (rustdoc: Fix visibility of trait and impl items)
 - rust-lang#81298 (replace RefCell with Cell in FnCtxt)
 - rust-lang#81301 (Fix small typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7038bb1 into rust-lang:master Jan 24, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 24, 2021
@jyn514 jyn514 deleted the resolve-timing branch January 24, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically A-self-profile Area: Self-profiling feature of the compiler S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants