Skip to content

Test the effect of shrinking the size of Rvalue by 16 bytes #82727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2021
Merged

Test the effect of shrinking the size of Rvalue by 16 bytes #82727

merged 2 commits into from
Mar 8, 2021

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 3, 2021

r? @ghost

@oli-obk

This comment has been minimized.

Sign in to view
@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2021
@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Mar 4, 2021

⌛ Trying commit bf08203936361c98002a9018b35304ad52b68886 with merge fe1d496e550e5902514bf91cb314f7ffa8813ec6...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPC-zz Dylan-DPC-zz added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Mar 4, 2021
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 4, 2021

@rust-timer queue fe1d496e550e5902514bf91cb314f7ffa8813ec6

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 4, 2021

@rust-timer build fe1d496e550e5902514bf91cb314f7ffa8813ec6

@rust-timer
Copy link
Collaborator

Queued fe1d496e550e5902514bf91cb314f7ffa8813ec6 with parent 7f32f62, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (fe1d496e550e5902514bf91cb314f7ffa8813ec6): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 4, 2021
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 4, 2021 •
edited
Loading

Looks fairly green on max-rss and idk where the (small) perf regressions come from. They are in llvm!? How can changing the size of rustc datastructures change how fast llvm optimizes? EDIT: I am guessing it's just noise

bjorn3
bjorn3 reviewed Mar 5, 2021
View reviewed changes
@pnkfelix pnkfelix self-requested a review March 5, 2021 17:01
@pnkfelix
Copy link
Contributor

pnkfelix commented Mar 5, 2021

@bors r+ rollup=never

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2021
@JohnTitor
Copy link
Member 

2021-03-06T21:00:28.1413391Z Caused by:
2021-03-06T21:00:28.1414116Z   failed to get 200 response from `https://crates.io/api/v1/crates/num-integer/0.1.43/download`, got 502

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2021
@bors
Copy link
Collaborator

bors commented Mar 7, 2021

⌛ Testing commit 9a2362e with merge a537903c41befc0bc0177c6da77b1a42710274cb...

@bors
Copy link
Collaborator

bors commented Mar 7, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 7, 2021
@JohnTitor
Copy link
Member

cc #82221, the timeout rate is a little too high these days :/
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Mar 7, 2021

⌛ Testing commit 9a2362e with merge 10a367799d70c08c6d7ef853eaffceac321b1eaa...

@bors
Copy link
Collaborator

bors commented Mar 7, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 7, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 7, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2021
@bors
Copy link
Collaborator

bors commented Mar 8, 2021

⌛ Testing commit 9a2362e with merge 27885a9...

@bors
Copy link
Collaborator

bors commented Mar 8, 2021

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 27885a9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2021
@bors bors merged commit 27885a9 into rust-lang:master Mar 8, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 8, 2021
@oli-obk oli-obk deleted the shrinkmem branch March 8, 2021 12:03
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 11, 2021
@bors
Auto merge of rust-lang#82727 - oli-obk:shrinkmem, r=pnkfelix
f3b68d3 
Test the effect of shrinking the size of Rvalue by 16 bytes

r? `@ghost`
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 29, 2021
@bors
Auto merge of rust-lang#82727 - oli-obk:shrinkmem, r=pnkfelix
7f02020 
Test the effect of shrinking the size of Rvalue by 16 bytes

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

+1 more reviewer

@pnkfelix pnkfelix pnkfelix approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
9 participants
@oli-obk @rust-timer @bors @rust-log-analyzer @pnkfelix @bjorn3 @JohnTitor @Dylan-DPC-zz @rustbot