Skip to content

Conversation

cjgillot
Copy link
Contributor

Split from #80347

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2021
@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Trying commit ab17829 with merge f385c2df516c51b489279617f62ac9e6d3247628...

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

☀️ Try build successful - checks-actions
Build commit: f385c2df516c51b489279617f62ac9e6d3247628 (f385c2df516c51b489279617f62ac9e6d3247628)

@rust-timer
Copy link
Collaborator

Queued f385c2df516c51b489279617f62ac9e6d3247628 with parent 178bd91, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f385c2df516c51b489279617f62ac9e6d3247628): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Mar 14, 2021

Huh... this regresses rustdoc? Idk how rustdoc handles metadata, but that seems very odd. Should we ping the rustdoc team?

@cjgillot
Copy link
Contributor Author

TBH, all the differences are <1%, so I barely looked at them.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 14, 2021

Yea... I'm fine regressing rustdoc a bit, but it would still be nice to track it, since it seems like a symptom of a deeper thing (I don't think this PR should affect rustdoc, and the fact that it does speaks for rustdoc doing something odd)

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 14, 2021

📌 Commit ab17829 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2021
@bors
Copy link
Collaborator

bors commented Mar 14, 2021

⌛ Testing commit ab17829 with merge 9320b12...

@bors
Copy link
Collaborator

bors commented Mar 14, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9320b12 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2021
@bors bors merged commit 9320b12 into rust-lang:master Mar 14, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 14, 2021
@cjgillot cjgillot deleted the defkey-ii branch March 14, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants