Don't rebuild rustdoc and clippy after checking bootstrap #84484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`.
jyn514
added
T-bootstrap
rust-highfive
added
the
S-waiting-on-review
| @@ -321,11 +321,9 @@ macro_rules! tool_check_step { | |||
| } | |||
|
|
|||
| // Enable internal lints for clippy and rustdoc | |||
There was a problem hiding this comment.
Uh, this comment seems odd or at least in need of updates - mind removing it I guess?
Are we gating internal lints on a CLI flag being passed? I guess we're enabling them on the CLI so that makes some sense, but then I'm not sure why this piece of code is in check.rs vs. Builder::cargo or so, alongside actually enabling the lints.
Generally deny(rustc::internal) isn't quite what we want in-code too, as we want deny-warnings=false to work locally...
There was a problem hiding this comment.
Are we gating internal lints on a CLI flag being passed?
Yes, the compiler doesn't run internal lints unless -Z unstable-options is passed, even if you have #[warn(rustc::internal)].
Generally deny(rustc::internal) isn't quite what we want in-code too, as we want deny-warnings=false to work locally...
Oh good point - I'll fix it in rustdoc and update the comment.
There was a problem hiding this comment.
Oh good point - I'll fix it in rustdoc and update the comment.
Done.
These should still obey deny-warnings.
|
@bors r+ rollup |
|
📌 Commit 1c8e122 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 28, 2021
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? `@Mark-Simulacrum`
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? ``@Mark-Simulacrum``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#84484 (Don't rebuild rustdoc and clippy after checking bootstrap) - rust-lang#84530 (`test tidy` should ignore alternative `build` dir patterns) - rust-lang#84531 (Ignore commented out lines when finding features) - rust-lang#84540 (Build sanitizers for x86_64-unknown-linux-musl) - rust-lang#84555 (Set `backtrace-on-ice` by default for compiler and codegen profiles) - rust-lang#84585 (Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc`) - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) - rust-lang#84646 (Add some regression tests related to rust-lang#82494) - rust-lang#84661 (Remove extra word in `rustc_mir` docs) - rust-lang#84663 (Remove `DropGuard` in `sys::windows::process` and use `StaticMutex` instead) - rust-lang#84668 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 6, 2021
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? ```@Mark-Simulacrum```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by unconditionally passing -Z unstable-options to the
compiler. This has no affect in practice since bootstrap doesn't use
deny(rustc::internal).Fixes #82461.
r? @Mark-Simulacrum