Skip to content

Avoid predecessors having Drop impls #85065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2021

Conversation

Mark-Simulacrum
Copy link
Member

Should be a simple win - but let's make sure with perf.

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 8, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2021
@bors
Copy link
Collaborator

bors commented May 8, 2021

⌛ Trying commit 0367e24 with merge e3407ab7a490155d6a4afa07bfc13c60b79aa1f1...

@bors
Copy link
Collaborator

bors commented May 8, 2021

☀️ Try build successful - checks-actions
Build commit: e3407ab7a490155d6a4afa07bfc13c60b79aa1f1 (e3407ab7a490155d6a4afa07bfc13c60b79aa1f1)

@rust-timer
Copy link
Collaborator

Queued e3407ab7a490155d6a4afa07bfc13c60b79aa1f1 with parent 467253f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e3407ab7a490155d6a4afa07bfc13c60b79aa1f1): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 8, 2021
@Mark-Simulacrum
Copy link
Member Author

Seems like either a small improvement or almost no change, but also seems likely to have larger effects if we start calling predecessors more. Intuitively this should be a little better; I'm inclined to merge.

@jackh726
Copy link
Member

jackh726 commented May 9, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2021

📌 Commit 0367e24 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2021
@bors
Copy link
Collaborator

bors commented May 9, 2021

⌛ Testing commit 0367e24 with merge ca82264...

@bors
Copy link
Collaborator

bors commented May 9, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing ca82264 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2021
@bors bors merged commit ca82264 into rust-lang:master May 9, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 9, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the preds-no-alloc branch May 9, 2021 21:21
@bors bors mentioned this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants