-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Avoid predecessors having Drop impls #85065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0367e24 with merge e3407ab7a490155d6a4afa07bfc13c60b79aa1f1... |
☀️ Try build successful - checks-actions |
Queued e3407ab7a490155d6a4afa07bfc13c60b79aa1f1 with parent 467253f, future comparison URL. |
Finished benchmarking try commit (e3407ab7a490155d6a4afa07bfc13c60b79aa1f1): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Seems like either a small improvement or almost no change, but also seems likely to have larger effects if we start calling predecessors more. Intuitively this should be a little better; I'm inclined to merge. |
@bors r+ |
📌 Commit 0367e24 has been approved by |
☀️ Test successful - checks-actions |
Should be a simple win - but let's make sure with perf.