Disable the machine outliner by default #86020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This addresses a codegen-issue that needs to be fixed upstream in LLVM. While we wait for the fix, we can disable it. Verified manually that the outliner is no longer run when `-Copt-level=z` is specified, and also that you can override this with `-Cllvm-args=-enable-machine-outliner` if you need it anyway. A regression test is not really feasible in this instance, given that we do not have any minimal reproducers. Fixes rust-lang#85351
nagisa
added
T-compiler
|
@bors r+ p=10 |
|
📌 Commit c63a1c0 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never Changing LLVM optimization options can affect perf. |
rustbot
added
the
beta-accepted
|
☀️ Test successful - checks-actions |
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2021
…ulacrum [beta] backports * Disable the machine outliner by default rust-lang#86020 * Fix incorrect gating of nonterminals in key-value attributes rust-lang#85445 * Build crtbegin.o/crtend.o from source code rust-lang#85395 * Bring back x86_64-sun-solaris target to rustup rust-lang#85252 * Preserve SyntaxContext for invalid/dummy spans in crate metadata rust-lang#85211 * [beta] backport: Remove unsound TrustedRandomAccess implementations rust-lang#86222 r? `@Mark-Simulacrum`
robin-nitrokey
added a commit
to robin-nitrokey/solo2
that referenced
this pull request
Jul 5, 2021
Rust 1.53.0 automatically sets the --enable-machine-outliner=never LLVM argument [0] [1]. As we also set this option in runners/lpc55/.cargo/config, we currently get a compliation error. This patch removes the option from our cargo configuration to fix the build. [0] rust-lang/rust@c63a1c0 [1] rust-lang/rust#86020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2021
Revert "Disable the machine outliner by default" The fix commit is already in the fork: rust-lang/llvm-project@6c78dbd4ca1f Linked: - rust-lang#85351 - rust-lang#86020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a codegen-issue that needs to be fixed upstream in LLVM.
While we wait for the fix, we can disable it.
Verified manually that the outliner is no longer run when
-Copt-level=zis specified, and also that you can override this with-Cllvm-args=-enable-machine-outlinerif you need it anyway.A regression test is not really feasible in this instance, given that we
do not have any minimal reproducers.
Fixes #85351
cc @pnkfelix