Skip to content

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 8, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 8, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 8, 2021
@bors
Copy link
Collaborator

bors commented Jun 8, 2021

⌛ Trying commit aeb050d with merge 96aeb2380405b6f6544cc66cf76ba8915b13aefe...

@bors
Copy link
Collaborator

bors commented Jun 8, 2021

☀️ Try build successful - checks-actions
Build commit: 96aeb2380405b6f6544cc66cf76ba8915b13aefe (96aeb2380405b6f6544cc66cf76ba8915b13aefe)

@rust-timer
Copy link
Collaborator

Queued 96aeb2380405b6f6544cc66cf76ba8915b13aefe with parent a50d721, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (96aeb2380405b6f6544cc66cf76ba8915b13aefe): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2021
@michaelwoerister
Copy link
Member

Thanks, @cjgillot! That looks like a straightforward simplification.

@bors r+

PS.: It's really time to make progress on that odht PR...

@bors
Copy link
Collaborator

bors commented Jun 9, 2021

📌 Commit aeb050d has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2021
@bors
Copy link
Collaborator

bors commented Jun 9, 2021

⌛ Testing commit aeb050d with merge 47d3875...

@bors
Copy link
Collaborator

bors commented Jun 9, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 47d3875 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2021
@bors bors merged commit 47d3875 into rust-lang:master Jun 9, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 9, 2021
@cjgillot cjgillot deleted the notable branch June 9, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants