Escape item search summaries #87331
Merged
Escape item search summaries #87331
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-rustdoc-search
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Test case/// Construct a new `Pin<P>` with this function.
pub fn new() {}Output (before)
Output (after)
|
camelid
commented
Jul 21, 2021
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
summary-escaping
branch
from
af606b1 to
1ac65cb
Compare
camelid
force-pushed
the
summary-escaping
branch
from
1ac65cb to
bab60b2
Compare
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
summary-escaping
branch
from
bab60b2 to
343a6bc
Compare
This comment has been minimized.
This comment has been minimized.
camelid
force-pushed
the
summary-escaping
branch
3 times, most recently
from
e9af1f8 to
8c816dd
Compare
GuillaumeGomez
approved these changes
Jul 24, 2021
|
Thanks! r=me once CI pass. |
|
📌 Commit 8c816dd4d1ec36050baf8195078267232e8df2a5 has been approved by |
bors
added
S-waiting-on-bors
|
Weird... CI passed but I had accidentally removed the import of EDIT: It looks like that import was added after the merge-base of this PR, and because CI merges before testing, it was as if the import was appearing in this PR magically 😅 |
camelid
force-pushed
the
summary-escaping
branch
from
8c816dd to
95a9d20
Compare
I noticed that `Pin::new()`'s search summary looked off, and I realized that the reason is that it has inline code containing `Pin<P>`, which is not escaped and thus renders as a paragraph tag!
camelid
force-pushed
the
summary-escaping
branch
from
95a9d20 to
4ad2d68
Compare
|
📌 Commit 4ad2d68 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Pin::new()'s search summary looked off, and I realizedthat the reason is that it has inline code containing
Pin<P>, which isnot escaped and thus renders as a paragraph tag!