Try to reuse buffers in String::extend #89169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the logic around buffer reuse in
FromIterator<String> for String
intoExtend
and a few otherFromIterator
implementations. Basically, in cases where we're extending from allocated types (String
,Cow<str>
,Box<str>
), we check ifself
is empty and, if so, just take the incoming value by move rather than copying the data.Follow up to #56548.