rustdoc: Don't show hidden trait methods #89198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @jyn514 |
Kobzol
reviewed
Sep 23, 2021
hkmatsumoto
force-pushed
the
hide-hidden-methods
branch
from
9ebb034 to
6b0a4b1
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
added
the
T-rustdoc
jyn514
suggested changes
Sep 23, 2021
There was a problem hiding this comment.
Can you add a test for this? It would go in src/test/rustdoc, there are instructions at https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html#dotting-is-and-crossing-ts :)
The code looks great though!
jyn514
added
S-waiting-on-author
hkmatsumoto
force-pushed
the
hide-hidden-methods
branch
from
6b0a4b1 to
94abbe8
Compare
|
|
hkmatsumoto
added
S-waiting-on-review
jyn514
reviewed
Sep 23, 2021
jyn514
added
S-waiting-on-author
hkmatsumoto
force-pushed
the
hide-hidden-methods
branch
from
94abbe8 to
9fef224
Compare
hkmatsumoto
added
S-waiting-on-review
By skipping trait items whose attributes include `hidden`, we void showing such trait methods.
hkmatsumoto
force-pushed
the
hide-hidden-methods
branch
from
9fef224 to
3239f06
Compare
jyn514
approved these changes
Sep 25, 2021
|
@bors delegate=hkmatsumoto |
|
✌️ @hkmatsumoto can now approve this pull request |
Co-authored-by: Joshua Nelson <[email protected]>
|
@bors r=jyn514 |
|
📌 Commit 195f752 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2021
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88895 (rustdoc: Cleanup `clean` part 2) - rust-lang#88973 (Expose the std_detect env_override feature) - rust-lang#89010 (Add some intra doc links) - rust-lang#89198 (rustdoc: Don't show hidden trait methods) - rust-lang#89216 (Consistent big O notation) - rust-lang#89224 (Change the order of imports suggestions) - rust-lang#89256 (Fix typo in release notes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@hkmatsumoto thank you for fixing this, it's awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89186.
By skipping trait items whose attributes include
hidden, we avoid showing such trait methods.