Skip to content

Remove unused CSS rule #89736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

GuillaumeGomez
Copy link
Member

As you can see in the firefox devtools:

Screenshot from 2021-10-10 14-28-08

It needs the display to be grid or inline-grid, which isn't the case.

r? @dns2utf8

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 10, 2021
@@ -773,8 +773,6 @@ h2.small-section-header > .anchor {

.item-table {
display: table-row;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: table-row;
display: table;

I just realised this should be table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in another PR (either you or me).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@GuillaumeGomez
Copy link
Member Author

@bors: r=dns2utf8 rollup

@bors
Copy link
Collaborator

bors commented Oct 10, 2021

📌 Commit 5611b43 has been approved by dns2utf8

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 10, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2021
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#89579 (Add regression test for issue 80108)
 - rust-lang#89632 (Fix docblock code display on mobile)
 - rust-lang#89691 (Move `DebuggerCommands` and `check_debugger_output` to a separate module)
 - rust-lang#89707 (Apply clippy suggestions for std)
 - rust-lang#89722 (Fix spelling: Cannonical -> Canonical)
 - rust-lang#89736 (Remove unused CSS rule)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bf01a59 into rust-lang:master Oct 11, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 11, 2021
@GuillaumeGomez GuillaumeGomez deleted the rm-unused-css-rule branch October 11, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants