Rollup of 7 pull requests #89984
Merged
Rollup of 7 pull requests #89984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rint_visible_def_path_recur`.
ty::pretty: prevent infinite recursion for `extern crate` paths. Fixes rust-lang#55779, fixes rust-lang#87932. This fix is based on `@estebank's` idea in rust-lang#55779 (comment) - but instead of trying to get `try_print_visible_def_path_recur`'s cycle detection to work in this case, this PR "just" disables the "visible path" feature when printing the path to an `extern crate`, so that the old recursion chain of `try_print_visible_def_path -> print_def_path -> try_print_visible_def_path`, is now impossible. Both tests have been confirmed to crash `rustc` because of a stack overflow, without the fix.
…arm64, r=Mark-Simulacrum Make `llvm.download-ci-llvm="if-available"` work for tier 2 targets with host tools `llvm.download-ci-llvm="if-available"` is used for most profiles configured via `x.py setup`. It allows downloading prebuilt LLVM tarballs from the CI artifacts for a configured list of platforms. Currently this list is restricted to tier 1 targets but it makes sense for all tier 2 targets with host tools.
…rom-slice, r=the8472 Remove a mention to `copy_from_slice` from `clone_from_slice` doc Fixes rust-lang#84736 I think removing it would be the best but I'm happy to clarify it instead if someone would like.
Fix an ICE with TAITs and Future Fixes rust-lang#89686
…=nagisa Some "parenthesis" and "parentheses" fixes "Parenthesis" is the singular (e.g. one `(` or one `)`) and "parentheses" is the plural (multiple `(` or `)`s) and this is not hard to mix up so here are some fixes for that. Inspired by rust-lang#89958
Add a regression test for rust-lang#85921 Closes rust-lang#85921 r? `@jackh726`
Make Result::as_mut const Adding `const` for `Result::as_mut`. Tracking issue: rust-lang#82814
|
@bors r+ rollup=never p=7 |
|
📌 Commit f044a84 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1f12ac8): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
extern cratepaths. #89738 (ty::pretty: prevent infinite recursion forextern cratepaths.)llvm.download-ci-llvm="if-available"work for tier 2 targets with host tools #89888 (Makellvm.download-ci-llvm="if-available"work for tier 2 targets with host tools)copy_from_slicefromclone_from_slicedoc #89945 (Remove a mention tocopy_from_slicefromclone_from_slicedoc)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup