Run gyp with CFG_PYTHON which is python < 3 #9041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for systems where /usr/bin/python is actually python 3
bors
added a commit
that referenced
this pull request
Sep 7, 2013
This is required for systems where /usr/bin/python is actually python 3 I already did this before, but forgot to re-port it once libuv was re-upgraded
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
rustc comiler internals helpfully tell us how to fix the issue: to get the signature of a closure, use `substs.as_closure().sig()` not `fn_sig()` Fixes ICE in rust-lang#9041
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Fix ICE in sugg::DerefDelegate with (named) closures rustc comiler internals helpfully tell us how to fix the issue: ``` to get the signature of a closure, use `substs.as_closure().sig()` not `fn_sig()` ``` Fixes ICE in rust-lang#9041 This also makes this code in `sugg::DerefDelegate` match a different use `typ.fn_sig(…)` I found: in `mixed_read_write_in_expression` -- being strict on the value of `typ.kind()` will hopefully reduce any future possibility of ICE crashes in this area. --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for systems where /usr/bin/python is actually python 3
I already did this before, but forgot to re-port it once libuv was re-upgraded