Fix pretty-printing of empty impl items #9061
Conversation
|
|
||
| if methods.len() == 0 { | ||
| word(s.s, ";"); | ||
| end(s); // end the head-ibox | ||
| end(s); // end the outer cbox |
There was a problem hiding this comment.
I'm personally very unfamiliar with this code, but looking at it, could you explain why there's two calls to end here? it looks like one of them is the complement of the above head call, and I was just wondering what the "outer cbox" was.
There was a problem hiding this comment.
@alexcrichton My understanding of this is very limited too but I think head() opens two blocks (as can be seen in https://github.com/jakub-/rust/blob/7173b9d1b8475bf2b44e50b78501f45f98c76bc0/src/libsyntax/print/pprust.rs#L246).
impl Trait for T {
fn foo() -> uint { 42 }
}
One spanning "impl Trait for T" (presumably so you can indent properly when you're wrapping a header that's too long?), and other one spanning the whole thing up to }.
There was a problem hiding this comment.
Sounds good to me, thanks for the explanation!
|
I guess this will pretty-print |
|
@huonw That is right, though that's what it used to before too. The problem was that in the case of an empty impl, it would end up at an incorrect indentation level. |
|
The error flagged by bors here looks legitimate. Can you update your test case? |
Use an existing type so that it compiles.
|
@pnkfelix Fixed, sorry about that! Didn't realize the pretty tests were compiled too. |
No description provided.