Fix bug with #[doc] string single-character last lines
#90657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @jyn514 |
klensy
reviewed
Nov 6, 2021
GuillaumeGomez
force-pushed
the
one-char-last-line-removed
branch
from
d267a87 to
aa6f6f4
Compare
camelid
changed the title
#[doc] string single-character last lines
|
@bors r+ |
|
📌 Commit aa6f6f4 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit aa6f6f4 with merge df8241381c2c29fe5899f211a53c2125c86c165e... |
|
@bors: retry |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2021
…emoved, r=jyn514 Fix bug with `#[doc]` string single-character last lines Fixes rust-lang#90618. This is because `.iter().all(|c| c == '*')` returns `true` if there is no character checked. And in case the last line has only one character, it simply returns `true`, making the last line behind removed.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2021
…emoved, r=jyn514 Fix bug with `#[doc]` string single-character last lines Fixes rust-lang#90618. This is because `.iter().all(|c| c == '*')` returns `true` if there is no character checked. And in case the last line has only one character, it simply returns `true`, making the last line behind removed.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2021
…emoved, r=jyn514 Fix bug with `#[doc]` string single-character last lines Fixes rust-lang#90618. This is because `.iter().all(|c| c == '*')` returns `true` if there is no character checked. And in case the last line has only one character, it simply returns `true`, making the last line behind removed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2021
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#90494 (ARMv6K Horizon OS panic change) - rust-lang#90652 (use filter(|x| matches!(..)) instead of filter_map(|x| match x ... => Some(xy))) - rust-lang#90657 (Fix bug with `#[doc]` string single-character last lines) - rust-lang#90689 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90618.
This is because
.iter().all(|c| c == '*')returnstrueif there is no character checked. And in case the last line has only one character, it simply returnstrue, making the last line behind removed.