Skip to content

ast: Avoid aborts on fatal errors thrown from mutable AST visitor #91519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

ast: Avoid aborts on fatal errors thrown from mutable AST visitor #91519

merged 1 commit into from
Dec 30, 2021

Conversation

petrochenkov
Copy link
Contributor

Set the node to some dummy value and rethrow the error instead.

When using the old aborting visit_clobber in InvocationCollector::visit_crate the next tests abort due to fatal errors:

ui\modules\path-invalid-form.rs
ui\modules\path-macro.rs
ui\modules\path-no-file-name.rs
ui\parser\issues\issue-5806.rs
ui\parser\mod_file_with_path_attr.rs

Follow up to #91313.

@petrochenkov
ast: Avoid aborts on fatal errors thrown from mutable AST visitor
bdb851f 
Set the node to some dummy value and rethwor the error instead.
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 9, 2021
@petrochenkov
Copy link
Contributor Author

r? @Aaron1011

@Aaron1011
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2021

📌 Commit bdb851f has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2021
@bors
Copy link
Collaborator

bors commented Dec 30, 2021

⌛ Testing commit bdb851f with merge b3cab488212d8ad2246c1e80b46a7dca2f7d781a...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Dec 30, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2021
@petrochenkov
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 30, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2021
@bors
Auto merge of rust-lang#92434 - matthiaskrgr:rollup-m8wuq0v, r=matthi…
b60e32c 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#91519 (ast: Avoid aborts on fatal errors thrown from mutable AST visitor)
 - rust-lang#92414 (Fix spacing of pretty printed const item without body)
 - rust-lang#92423 (Add UI test for rust-lang#92292)
 - rust-lang#92427 (Use `UnsafeCell::get_mut()` in `core::lazy::OnceCell::get_mut()`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b9f7197 into rust-lang:master Dec 30, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 30, 2021
@Alexendoo Alexendoo mentioned this pull request Dec 31, 2021
Closed
@dwrensha dwrensha mentioned this pull request Jan 1, 2022
Closed
@ehuss ehuss mentioned this pull request Jan 6, 2024
Closed
nnethercote added a commit to nnethercote/rust that referenced this pull request Mar 1, 2024
@nnethercote
Remove DummyAstNode.
691e788 
It was added in rust-lang#91519 to allow `visit_clobber` to be used in one extra
place, but is seemingly no longer needed.
@nnethercote nnethercote mentioned this pull request Mar 1, 2024
Merged
@petrochenkov petrochenkov deleted the cratexp2 branch February 22, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @Aaron1011 @bors @rust-log-analyzer @apiraino @matthewjasper @rustbot