Extend toggle GUI test a bit #94155
Merged
Extend toggle GUI test a bit #94155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
jsha
reviewed
Feb 25, 2022
| assert-attribute: ("details.rustdoc-toggle", {"open": ""}, ALL) | ||
| // We collapse them all. | ||
| click: "#toggle-all-docs" | ||
| wait-for: 1000 |
There was a problem hiding this comment.
This wait-for (1 second) is much too long. I think we can reduce it to 50ms and still be very reliable without slowing down tests too much.
jsha
reviewed
Feb 25, 2022
| ) | ||
| // We open them all again. | ||
| click: "#toggle-all-docs" | ||
| wait-for: 1000 |
There was a problem hiding this comment.
This wait-for should also be shortened.
Other than that, this change looks good! r=me once those are fixed.
GuillaumeGomez
force-pushed
the
extend-toggle-gui-test
branch
from
e3f11e6 to
ec50cdb
Compare
|
Good idea! I updated with your suggestion. @bors: r=jsha rollup |
|
📌 Commit ec50cdb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#93845 (Remove in band lifetimes) - rust-lang#94155 (Extend toggle GUI test a bit) - rust-lang#94252 (don't special case `DefKind::Ctor` in encoding) - rust-lang#94305 (Remove an unnecessary restriction in `dest_prop`) - rust-lang#94343 (Miri fn ptr check: don't use conservative null check) - rust-lang#94344 (diagnostic: suggest parens when users want logical ops, but get closures) - rust-lang#94352 (Fix SGX docs build) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84422.
r? @jsha