Skip to content

fix two comments referring to moved code (now rustc_mir_transform::generator) #95156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

audunhalland
Copy link
Contributor

This caused me some confusion when trying to find the related code.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 20, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2022
@Dylan-DPC
Copy link
Member

@bors r=Dylan-DPC rollup

@bors
Copy link
Collaborator

bors commented Mar 21, 2022

📌 Commit cd762d8 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2022
@bors
Copy link
Collaborator

bors commented Mar 21, 2022

⌛ Testing commit cd762d8 with merge eded76b...

@bors
Copy link
Collaborator

bors commented Mar 21, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing eded76b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 21, 2022
@bors bors merged commit eded76b into rust-lang:master Mar 21, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eded76b): comparison url.

Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@audunhalland audunhalland deleted the fix-rustc_const_eval_transform-comments branch March 22, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants