Skip to content

Suggest constraining param for unary ops when missing trait impl #95197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions compiler/rustc_typeck/src/check/op.rs
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,27 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
ex.span,
format!("cannot apply unary operator `{}`", op.as_str()),
);
let missing_trait = match op {
hir::UnOp::Deref => unreachable!("check unary op `-` or `!` only"),
hir::UnOp::Not => "std::ops::Not",
hir::UnOp::Neg => "std::ops::Neg",
};
let mut visitor = TypeParamVisitor(vec![]);
visitor.visit_ty(operand_ty);
if let [ty] = &visitor.0[..] {
if let ty::Param(p) = *operand_ty.kind() {
suggest_constraining_param(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I just followed what check_overloaded_binop does, I'm not sure if the passed arguments are right.

self.tcx,
self.body_id,
&mut err,
*ty,
operand_ty,
missing_trait,
p,
true,
);
}
}

let sp = self.tcx.sess.source_map().start_point(ex.span);
if let Some(sp) =
Expand Down
6 changes: 6 additions & 0 deletions src/test/ui/type/type-check/missing_trait_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@ fn foo<T>(x: T, y: T) {
fn bar<T>(x: T) {
x += x; //~ ERROR binary assignment operation `+=` cannot be applied to type `T`
}

fn baz<T>(x: T) {
let y = -x; //~ ERROR cannot apply unary operator `-` to type `T`
let y = !x; //~ ERROR cannot apply unary operator `!` to type `T`
let y = *x; //~ ERROR type `T` cannot be dereferenced
}
32 changes: 30 additions & 2 deletions src/test/ui/type/type-check/missing_trait_impl.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,35 @@ help: consider restricting type parameter `T`
LL | fn bar<T: std::ops::AddAssign>(x: T) {
| +++++++++++++++++++++

error: aborting due to 2 previous errors
error[E0600]: cannot apply unary operator `-` to type `T`
--> $DIR/missing_trait_impl.rs:13:13
|
LL | let y = -x;
| ^^ cannot apply unary operator `-`
|
help: consider restricting type parameter `T`
|
LL | fn baz<T: std::ops::Neg<Output = T>>(x: T) {
| +++++++++++++++++++++++++++

error[E0600]: cannot apply unary operator `!` to type `T`
--> $DIR/missing_trait_impl.rs:14:13
|
LL | let y = !x;
| ^^ cannot apply unary operator `!`
|
help: consider restricting type parameter `T`
|
LL | fn baz<T: std::ops::Not<Output = T>>(x: T) {
| +++++++++++++++++++++++++++

error[E0614]: type `T` cannot be dereferenced
--> $DIR/missing_trait_impl.rs:15:13
|
LL | let y = *x;
| ^^

error: aborting due to 5 previous errors

Some errors have detailed explanations: E0368, E0369.
Some errors have detailed explanations: E0368, E0369, E0600, E0614.
For more information about an error, try `rustc --explain E0368`.