Skip to content

Conversation

SparrowLii
Copy link
Member

@SparrowLii SparrowLii commented Apr 24, 2022

This PR:

  1. fixes the FIXME of classify_drop_access_kind func in the borrowck part. The process of obtaining StorageDeadOrDrop has been changed from recursive to iterative.
  2. gets place_ty in each iteration, avoid repeatedly getting the ty of the same place (O(n^2) => O(n))

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 24, 2022
@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Apr 24, 2022

@bors try @rust-timer queue

I don't expect perf changes, but let's make sure before rolling up

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 24, 2022
@bors
Copy link
Collaborator

bors commented Apr 24, 2022

⌛ Trying commit a34e1b5 with merge 7f71280f22cfccea406a5595cb1f3504279a0fd1...

@bors
Copy link
Collaborator

bors commented Apr 24, 2022

☀️ Try build successful - checks-actions
Build commit: 7f71280f22cfccea406a5595cb1f3504279a0fd1 (7f71280f22cfccea406a5595cb1f3504279a0fd1)

@rust-timer
Copy link
Collaborator

Queued 7f71280f22cfccea406a5595cb1f3504279a0fd1 with parent b21759f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7f71280f22cfccea406a5595cb1f3504279a0fd1): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 24, 2022

@bors r+ rollup

Excellent! Thanks for cleaning that up, I totally forgot we added it until your PR removed it

@bors
Copy link
Collaborator

bors commented Apr 24, 2022

📌 Commit a34e1b5 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@bors
Copy link
Collaborator

bors commented Apr 24, 2022

⌛ Testing commit a34e1b5 with merge d8e59ed...

@bors
Copy link
Collaborator

bors commented Apr 24, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d8e59ed to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2022
@bors bors merged commit d8e59ed into rust-lang:master Apr 24, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 24, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d8e59ed): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants