Skip to content

Conversation

Volker-Weissmann
Copy link
Contributor

I added this note, because if you forget the --target flags, you get a really ugly error message.
rust-lang/cargo#10666

I added this note, because if you forget the `--target` flags, you get a really ugly error message.
rust-lang/cargo#10666
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 15, 2022

📌 Commit 30108ca has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#96947 (Add rustc_nonnull_optimization_guaranteed to Owned/Borrowed Fd/Socket)
 - rust-lang#97021 (Added note in documentation)
 - rust-lang#97042 (Add new eslint rule about brace style)
 - rust-lang#97060 (Fix use of SetHandleInformation on UWP)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e8e7555 into rust-lang:master May 15, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 15, 2022
@Volker-Weissmann
Copy link
Contributor Author

Will this patch get backported to beta or stable?

@Mark-Simulacrum
Copy link
Member

I wouldn't expect it to be; it only affects nightly features and we typically do not backport documentation changes. The changes are already published here https://doc.rust-lang.org/nightly/unstable-book/compiler-flags/sanitizer.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants