Skip to content

Reverse condition in Vec::retain_mut doctest #97187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

Reverse condition in Vec::retain_mut doctest #97187

merged 1 commit into from
May 20, 2022

Conversation

ajtribick
Copy link
Contributor

I find that the doctest for Vec::retain_mut is easier to read and understand when the if block corresponds to the path that returns true and the else block returns false. Having the if block be the false path led me to stare at the example for somewhat longer than I probably had to.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 19, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2022
thomcc
thomcc approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree this is slightly clearer.

@bors r+

@thomcc
Copy link
Member

thomcc commented May 19, 2022

Uh, guess I can't put it there.

@bors r+

@bors
Copy link
Collaborator

bors commented May 19, 2022

📌 Commit 1a41a66 has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request May 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2022
@bors
Auto merge of rust-lang#97224 - matthiaskrgr:rollup-it5nw68, r=matthi…
536020c 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#97109 (Fix misleading `cannot infer type for type parameter` error)
 - rust-lang#97187 (Reverse condition in Vec::retain_mut doctest)
 - rust-lang#97201 (Fix typo)
 - rust-lang#97203 (Minor tweaks to rustc book summary formatting.)
 - rust-lang#97208 (Do not emit the lint `unused_attributes` for *inherent* `#[doc(hidden)]` associated items)
 - rust-lang#97215 (Add complexity estimation of iterating over HashSet and HashMap)
 - rust-lang#97220 (Add regression test for#81827)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit daf4f34 into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
@ajtribick ajtribick deleted the patch-1 branch May 20, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ajtribick @rust-highfive @thomcc @bors @rustbot