Skip to content

rustc: Fix ICE in native library error reporting #97328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

rustc: Fix ICE in native library error reporting #97328

merged 1 commit into from
May 25, 2022

Conversation

petrochenkov
Copy link
Contributor

Fixes #97299

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2022
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2022
@petrochenkov petrochenkov mentioned this pull request May 23, 2022
Closed
@petrochenkov petrochenkov added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels May 23, 2022
@petrochenkov
Copy link
Contributor Author

I'm going to add a stable backport nomination for the unlikely case of a point release, but this change by itself doesn't deserve a point release.

luqmana
luqmana approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelwoerister
Copy link
Member

Thanks for fixing that, @petrochenkov!

@bors r+

@bors
Copy link
Collaborator

bors commented May 25, 2022

📌 Commit c82a370 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2022
@petrochenkov
Copy link
Contributor Author

@bors rollup

@Dylan-DPC Dylan-DPC mentioned this pull request May 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2022
@bors
Auto merge of rust-lang#97401 - Dylan-DPC:rollup-fh9e61o, r=Dylan-DPC
1b5e121 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97302 (Do writeback of Closure params before visiting the parent expression)
 - rust-lang#97328 (rustc: Fix ICE in native library error reporting)
 - rust-lang#97351 (Output correct type responsible for structural match violation)
 - rust-lang#97398 (Add regression test for rust-lang#82830)
 - rust-lang#97400 (Fix a typo on Struct `Substructure`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0067078 into rust-lang:master May 25, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 25, 2022
@apiraino
Copy link
Contributor

Beta and stable backports accepted as per compiler team on Zulip

@rustbot label +beta-accepted +stable-accepted

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels May 26, 2022
@JohnTitor JohnTitor mentioned this pull request May 26, 2022
Closed
@ehuss ehuss modified the milestones: 1.63.0, 1.62.0 Jun 1, 2022
ehuss pushed a commit to ehuss/rust that referenced this pull request Jun 1, 2022
@Dylan-DPC @ehuss
Rollup merge of rust-lang#97328 - petrochenkov:nativice, r=michaelwoe…
054a2bd 
…rister

rustc: Fix ICE in native library error reporting

Fixes rust-lang#97299
@ehuss ehuss mentioned this pull request Jun 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2022
@bors
Auto merge of rust-lang#97631 - ehuss:update-beta-cargo, r=ehuss
a5cf77c 
[beta] Beta backports

* Allow the unused_macro_rules lint for now rust-lang#97032
* Fix some typos in arg checking algorithm rust-lang#97303
* rustc: Fix ICE in native library error reporting rust-lang#97328
* Cargo:
    * Fix `cargo publish -p spec` rust-lang/cargo#10707
@petrochenkov petrochenkov mentioned this pull request Jun 13, 2022
Closed
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 23, 2022
@Mark-Simulacrum Mark-Simulacrum removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Jul 15, 2022
@petrochenkov petrochenkov deleted the nativice branch February 22, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@luqmana luqmana luqmana approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@michaelwoerister michaelwoerister

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

mingw: panic when compiling rustc_llvm
9 participants
@petrochenkov @rust-highfive @michaelwoerister @bors @apiraino @luqmana @ehuss @Mark-Simulacrum @rustbot