Skip to content

Add sentence in case JS is disabled on settings.html page #97489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2022
Merged

Add sentence in case JS is disabled on settings.html page #97489

merged 2 commits into from
May 30, 2022

Conversation

GuillaumeGomez
Copy link
Member

Instead of having an empty page, it'll look like this:

Screenshot from 2022-05-28 17-46-23

r? @notriddle

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the settings-js-disabled branch from 284bbf7 to bfb16b9 Compare May 28, 2022 16:55
@GuillaumeGomez
Copy link
Member Author

And I forgot again that I need to use --test-args --no-sandbox... I should try to make browser-ui-test crash in such a case.

@notriddle
Copy link
Contributor

@bors r+ rollup

@notriddle notriddle closed this May 30, 2022
@notriddle notriddle reopened this May 30, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 30, 2022

📌 Commit bfb16b9 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2022
@bors
Copy link
Collaborator

bors commented May 30, 2022

⌛ Testing commit bfb16b9 with merge 855fc02...

@bors
Copy link
Collaborator

bors commented May 30, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 855fc02 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 30, 2022
@bors bors merged commit 855fc02 into rust-lang:master May 30, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 30, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (855fc02): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.3% 3.7% 2
Improvements 🎉
(primary)		 -2.4% -2.4% 1
Improvements 🎉
(secondary)		 -3.4% -3.5% 2
All 😿🎉 (primary) -2.4% -2.4% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -3.2% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.2% -3.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@GuillaumeGomez GuillaumeGomez deleted the settings-js-disabled branch May 30, 2022 08:56
@klensy klensy mentioned this pull request May 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @rust-log-analyzer @notriddle @bors @rust-timer @rust-highfive @rustbot