Skip to content

impl Neg for NonZeroI* #97907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

impl Neg for NonZeroI* #97907

wants to merge 1 commit into from

Conversation

iago-lito
Copy link
Contributor

@iago-lito iago-lito commented Jun 9, 2022 •
edited by pitaj
Loading

Insta-stable feature extracted from #97547.

@rust-highfive

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 9, 2022
@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2022
@iago-lito iago-lito force-pushed the impl_Neg_for_NonZeroI branch from 0763459 to e04b345 Compare June 9, 2022 07:37
@iago-lito iago-lito mentioned this pull request Jun 9, 2022
Merged
3 tasks
eggyal
eggyal reviewed Jun 9, 2022
View reviewed changes
@iago-lito iago-lito force-pushed the impl_Neg_for_NonZeroI branch from e04b345 to 3af148a Compare June 9, 2022 09:09
@scottmcm scottmcm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 24, 2022
@jmillikin
Copy link
Contributor

Out of curiosity, does this also mean that NonZeroI* will have saturating_neg() and checked_neg() functions?

@pitaj pitaj added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2023
@pitaj
Copy link
Contributor

pitaj commented May 5, 2023

@m-ou-se ping from triage, no movement for 8 months. What's the status of this PR? Is it ready for FCP?

@jmillikin
Copy link
Contributor

@pitaj I think this PR can be closed, as impl Neg for NonZeroI* was merged in #102341

@iago-lito
Copy link
Contributor Author

Yupe. Sorry for having neglected it. I'll go ahead and close this, assuming I was supposed to do this earlier ^ ^"

@iago-lito iago-lito closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eggyal eggyal eggyal left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@m-ou-se m-ou-se

Labels
needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@iago-lito @rust-highfive @jmillikin @pitaj @eggyal @m-ou-se @scottmcm @rustbot