Enable raw-dylib for bin crates #98778
Closed
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? rust-lang/compiler |
|
Thanks for the PR, @dpaoliello! Looks good to me. @bors r+ |
|
📌 Commit b8213bb has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
…erister Enable raw-dylib for bin crates Fixes rust-lang#93842 When a `raw-dylib` is used in a `bin` crate, we need to link to the library name specified.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
…erister Enable raw-dylib for bin crates Fixes rust-lang#93842 When a `raw-dylib` is used in a `bin` crate, we need to link to the library name specified.
|
@bors r- failed in a rollup |
bors
added
S-waiting-on-author
|
This is the incorrect fix: I need to dig into this more and will provide a new PR once I have the correct fix. |
|
New PR: !98989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93842
When a
raw-dylibis used in abincrate, we need to link to the library name specified.