from_method from rustc_on_unimplemented #2304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The italics added in rust-lang#1239 broke the implicitly-resolved link.
* Fix broken links in region_inference.md * Fix broken links in lifetime_parameters.md
Co-authored-by: pierwill <[email protected]>
…lang#1267) rust-lang/rust#91207 updates the coverage mapping format to Version 5 or 6, depending on the built-in version of LLVM (12 or 13, respectively). This change updates the dev guide to match the recent changes.
Co-authored-by: Joshua Nelson <[email protected]>
`NodeId`s are no longer used in the HIR. See #50928 for more information.
Use current paths when discussing source files. Update cheat sheet section with download-rustc. Add "use cases" section.
The inline code wasn't being rendered correctly.
* Move `x.py` intro section before first use, and shorten it. * Improve `x.py setup` docs. In "Getting Started", strip it back to the bare minimum. Some of this is moved into the later section. In the later section, add notable details like config.toml.example how and `profile` works. Also make the config.toml example more concise. * Move details about the repository. Less detail in "Getting Started", more in the later sections. * Move details about the prereqs. Less detail in "Getting Started", more in the later sections.
The section was removed in rust-lang#1030 and re-added in a different place in 2d42cf7.
This is a follow-up to rust-lang#1279. The "Getting Started" chapter is, TBH, pretty bad when it comes to the stuff about building and testing. It has far too much detail and lots of repetition, which would be overwhelming to a newcomer. This commit removes most of it, leaving behind just quick mentions of the most common `x.py` commands: `check`, `build`, `test`, `fmt`, with links to the appropriate chapters for details. There were a few interesting details that weren't covered elsewhere, so I moved those into other chapters.
Co-authored-by: mejrs <>
When doing a git grep (of rustc-dev-guide or of rust-lang/rust with --recurse-submodules), if the grep happens to match within the minified javascript, the resulting long single lines can cause a text pager or editor to slow down and distract from more useful matches. Minified javascript isn't formatted for human consumption, by definition, so mark it as binary, which causes git grep to instead just state that it matches without printing the matching "line".
Using `llvm.godbolt.org` subdomain should automatically select the correct LLVM-IR language.
Co-authored-by: Yuki Okushi <[email protected]>
As implemented in rust-lang/rust#103345
* Update `traits/resolution.md` Co-authored by: @lcnr and @spastorino * Update src/traits/resolution.md * Wrapping * Update src/traits/resolution.md Co-authored-by: Santiago Pastorino <[email protected]> Co-authored-by: Santiago Pastorino <[email protected]>
According to rust-lang/rust@8873e33 > Running with --bless causes the push to succeed if there are fixable formatting changes, but the changes don't make it into the push. > > We should have the user rerun with --bless (or x.py fmt) and commit the changes themselves (they might want to amend a particular commit, for instance).
Updated Diagnostic text to use the same language used in Subdiagnostic
* Fix some typos. Co-authored-by: pierwill <[email protected]>
- queries always need a description - `QueryDescription` isn't just for descriptions (it's actually not for descriptions at all now) and always implemented by the macro - queries are not grouped into categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was removed with rust-lang/rust#113453 but the documentation was never updated