-
Notifications
You must be signed in to change notification settings - Fork 545
Implicit Caller Location section. #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Probably an easy way to explain it is to show the definition and what it codegens as, both in regular Rust code (even if nothing before codegen, not even MIR, encodes the caller location passing). |
cc @nikomatsakis you had specifically asked for this to be able to learn more about the feature. Would love to hear if it achieves that goal! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a fabulous eventual stabilization report and some great technical writing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. I think it was just about the perfect level of detail -- outlined the high-level strategy without getting too bogged down in the implementation details. I imagine if you were paging through code, it'd be really helpful. One final note -- maybe we want to modify the code to link to this chapter? (Once it lands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @anp!
@anp Could you rebase on top of the most recent master? It has a bunch of link fixes. |
Actually just finished doing that, those breakages were from my own links 😅 -- fixed up. |
Documenting the overall feature here as the current implementation is spread across several PRs and has deviated a good bit from the RFC.
recommended in rust-lang/rust#47809 (comment)