Skip to content

Just lol #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2020
Merged

Just lol #603

merged 2 commits into from
Mar 8, 2020

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Mar 6, 2020

No description provided.

JohnTitor
JohnTitor reviewed Mar 6, 2020
View reviewed changes
@mark-i-m
Copy link
Member Author

mark-i-m commented Mar 7, 2020

Perhaps I need to escape it somehow

@JohnTitor
Copy link
Member

The change looks good! CI failures are unrelated, addressed by #604.

@JohnTitor
Copy link
Member

Merged that PR, could you rebase?

JohnTitor
JohnTitor approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTitor JohnTitor merged commit 0e8bd00 into master Mar 8, 2020
@spastorino
Copy link
Member

spastorino commented Mar 12, 2020 •
edited
Loading

It was funny to hear @pnkfelix on one of the last meetings talking about some ICE-breakers groups names like Windows breakers and ARM breakers

@JohnTitor JohnTitor deleted the mark-i-m-patch-2 branch March 18, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mark-i-m @JohnTitor @spastorino