Skip to content

add suggested workflow to setup nightly rustup for rust/ #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2020
Merged

add suggested workflow to setup nightly rustup for rust/ #883

merged 5 commits into from
Oct 4, 2020
+28 −1

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Sep 16, 2020 •
edited
Loading

Talked about this in zulip, this makes it to cargo fmt and editor integrations kindof just work

@jyn514 jyn514 self-assigned this Sep 16, 2020
@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Sep 16, 2020
jyn514
jyn514 reviewed Sep 16, 2020
View reviewed changes
@jyn514 jyn514 added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Sep 16, 2020
@guswynn
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9340b11 
Co-authored-by: Joshua Nelson <[email protected]>
@jyn514

This comment has been minimized.

Sign in to view
@camelid

This comment has been minimized.

Sign in to view
@mark-i-m
Copy link
Member

mark-i-m commented Oct 4, 2020

Pushed some of the suggested changes (hope that's ok @guswynn). Should be ready for final review now. Thanks @guswynn !

camelid
camelid reviewed Oct 4, 2020
View reviewed changes
@mark-i-m @camelid
Link to .md files, rather than .html

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cdec93c 
Co-authored-by: Camelid <[email protected]>
@mark-i-m mark-i-m added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Oct 4, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 4, 2020

Thanks for working on this!

@jyn514 jyn514 merged commit 5b895d7 into rust-lang:master Oct 4, 2020
@jyn514 jyn514 mentioned this pull request Oct 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m

@camelid camelid

@jyn514 jyn514

Assignees

@jyn514 jyn514

Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guswynn @jyn514 @camelid @mark-i-m