no perf run for rustc PR #90680 #1092
Description
For some reason, there no perf run for PR rust-lang/rust#90680. Queue is empty, runs for next and previous PR successfully finished.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
calebcartwright commentedon Nov 8, 2021
Are perf runs typically executed against PRs that only modify tool submodules/subtrees?
klensy commentedon Nov 8, 2021
I guess it runs on everything, for example it runs on RA updates, rust-lang/rust#90464
Mark-Simulacrum commentedon Nov 8, 2021
Yeah, this is some bug -- investigating.
calebcartwright commentedon Nov 8, 2021
Fair enough. I guess a more general question would be whether it's desirable to have perf runs for such submodule/subtree only changes?
Mark-Simulacrum commentedon Nov 8, 2021
Not entirely sure what happened but the results were posted just now after a manual database adjustment. I think we somehow didn't record the run in the right table, but I don't know what caused that.
We want to run perf on all commits to avoid any accidental regressions, even if we don't really expect it from a particular PR.