Add runtime benchmark cachegrind diff #1695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use the `rustc-demangle` crate to demangle Rust symbols.
This avoids the creation of needless `cgfilt` files when comparing two Cachegrind profiles. It also produces a demangled `cgout` file even without using Cachegrind diff.
Kobzol
force-pushed
the
runtime-cachegrind-diff
branch
from
727ea54 to
90118b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to compare two Cachegrind profiles of a runtime benchmark using
cg_diff. It also refactors similar functionality for compile time benchmarks, to allow reusing the implementation and remove some unneeded temporary files. The need to have an externalrustfiltbinary installed was also removed, demangling is now performed using therustc-demanglecrate.