Move Selector into database crate
#1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s7tya
force-pushed
the
move-selector-to-db-crate
branch
from
d050a36 to
e04183d
Compare
s7tya
force-pushed
the
move-selector-to-db-crate
branch
4 times, most recently
from
e04183d to
622148d
Compare
s7tya
force-pushed
the
move-selector-to-db-crate
branch
from
622148d to
b65e194
Compare
Kobzol
reviewed
Aug 5, 2024
s7tya
force-pushed
the
move-selector-to-db-crate
branch
2 times, most recently
from
b3d1e5c to
0c2fbb1
Compare
s7tya
force-pushed
the
move-selector-to-db-crate
branch
from
0c2fbb1 to
dba0c6b
Compare
Kobzol
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement #1734, it would be nice to move
Selectorfrom the site crate to the database crate.This PR will move Selector itself and related things into the database crate.
I left things like SiteCtxt that is only used in the site crate as it is.