Skip to content

Add include-blob secondary benchmark #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 30, 2025

I used a build script to generate the binary/string blobs, so that we don't have to commit these blobs into the repository. I thus also generated two files instead of one, just in case rustc decided to do something smart and deduplicate them.

Closes: #2171

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the comment addressed. Thanks!

@Kobzol
Copy link
Member Author

Kobzol commented Jun 30, 2025

Btw I used 30 MiB because 50 MiB already took several seconds (3-4) to compile, so it looked to be "big enough" 😆

@Kobzol Kobzol enabled auto-merge June 30, 2025 13:03
@Kobzol Kobzol merged commit 9a5818a into rust-lang:master Jun 30, 2025
9 of 11 checks passed
@Kobzol Kobzol deleted the include-blob branch June 30, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new stress benchmark for including huge binary blobs with include_bytes!
2 participants