Skip to content

feat: the C AST used by the C codegen backend #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 22, 2024
Merged

feat: the C AST used by the C codegen backend #6

merged 12 commits into from
Oct 22, 2024

Conversation

Wybxc
Copy link
Contributor

@Wybxc Wybxc commented Oct 18, 2024 •
edited
Loading

This PR adds rustc_codegen_c_ast crate for C AST construction and printing.

@Wybxc Wybxc marked this pull request as ready for review October 18, 2024 12:53
tgross35
tgross35 requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, the code is very clean and the docs help a lot. Some minor requests, then feel free to squash and we can merge this (or I can just squash merge).

@Wybxc Wybxc requested a review from tgross35 October 22, 2024 08:41
@tgross35 tgross35 merged commit aeb8fe5 into rust-lang:main Oct 22, 2024
5 checks passed
@tgross35 tgross35 mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wybxc @tgross35