Skip to content

Incremental formatting #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nrc opened this issue Sep 27, 2015 · 6 comments
Closed

Incremental formatting #385

nrc opened this issue Sep 27, 2015 · 6 comments
Labels

Comments

@nrc
Copy link
Member

nrc commented Sep 27, 2015

We should have a formatting mode where we take a date/time as an arg and only format files which have been modified after that date/time. In conjunction with a make file or cargo plugin, that would allow us to do incremental (at the file-level) re-formatting.

@kamalmarhubi
Copy link
Contributor

Could the aims of this be achieved by formatting based on a diff?

@nrc
Copy link
Member Author

nrc commented Jun 1, 2016

It could. It is a bit less flexible since it requires a diff which means you need to be running version control. OTOH, it would be more precise and thus less code would get reformatted. It does seem a much harder problem to solve too, although obviously it is a nice thing to have in its own right.

@topecongiro
Copy link
Contributor

Is this still a high priority?

@kamalmarhubi
Copy link
Contributor

@topecongiro you may also be interested in #434, and the initial work (almost a year ago now :/) in #1007.

@nrc nrc removed the p-high label May 4, 2017
@nrc
Copy link
Member Author

nrc commented May 4, 2017

@topecongiro It is not high priority, I think, though I would still like to do it (it would be very helpful, but only for very large codebases). #434 is much more important because it is useful for IDE support.

@topecongiro
Copy link
Contributor

@kamalmarhubi @nrc Thanks for comments! I will take a look at #434.

@nrc nrc added the p-low label Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants