Skip to content

comment-intentation regressions #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Boscop opened this issue Feb 12, 2020 · 0 comments · Fixed by #4055
Closed

comment-intentation regressions #4049

Boscop opened this issue Feb 12, 2020 · 0 comments · Fixed by #4055
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release

Comments

@Boscop
Copy link

Boscop commented Feb 12, 2020

After I updated to rustfmt 1.4.11-nightly (18382352 2019-12-03), I noticed some comment-intentation regressions:

Before:

			if let Some(MpcEv::PlayDrum(pitch, vel)) =
				// self.mpc.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
				self.mpc.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
			{

After:

			if let Some(MpcEv::PlayDrum(pitch, vel)) =
				// self.mpc.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
			 self.mpc.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
			{

And another one.
Before:

				if let Some(e) =
					// self.note_input.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
					self.note_input.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
				{

After:

				if let Some(e) =
					// self.note_input.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
				 self.note_input.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
				{

Notice: It inserts a single space after tab-indentation.

These are my settings:

edition = "2018"
version = "Two"
max_width = 110
newline_style = "Unix"
use_small_heuristics = "Max"
hard_tabs = true
merge_imports = true
reorder_impl_items = true
use_field_init_shorthand = true
use_try_shorthand = true
spaces_around_ranges = true
overflow_delimited_expr = true
@calebcartwright calebcartwright added the 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants