Handle multiline condition in let if else (fixes #1239) #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Jan 31, 2017
| width: shape.width, | ||
| indent: Indent { | ||
| block_indent: shape.indent.block_indent, | ||
| alignment: 0, |
There was a problem hiding this comment.
I don't think this is quite right, because the if/else could be nested inside an expression where the alignment should not be reset
There was a problem hiding this comment.
Do you have an example in mind? Because as I understand it, the } else if ... { part will always move back to the block indent, which is retained.
There was a problem hiding this comment.
Yeah, I think you're right, and you're passing the test suite, so it seems good.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside multiline conditions in nested else statements, remove the alignment due to the let binding before the original if statement. Fixes #1239.