Create imported_names_layout option #1760
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for #788. I have implemented the option using bare
ListTactic
, which now looking at the outcome, I see that it needs more work. But there are some open questions now:Do we want to support anything like "Visual" mode? I think not, but we need to make sure, to some level.
Would a trailing comma be optional in this list? Do we need to add an option for it? (Again, I think No and No.)
And the important question: should I just hard-code the "Block" style for "Vertical" option here, or should we split this option into two, or maybe create a new type for it, so we can have "Horizontal" and "Block" in one option. (I don't have an answer for this myself, but until I hear back, will try to get it work as "Block" with the simplest diff possible.)
Fixes #788