Fix make_diff with zero context requested #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! And love the tests :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1173, I found that calling
make_diffwithcontext_sizeof0didn't work properly (or at least not as I expected!): it sometimes includes aContextline (I think in the firstMismatch) and splits a contiguous chunk of changed lines into separateMismatches.I'm not completely convinced about what it does with
context_size>0and two changes closer than that together; it splits it into twoMismatchitems after the context lines between them. The Unix diff command merges them together. In any case, I don't think I've changed how that behaves.