fix rewrite_string when a line feed is present in a sequence of whitespaces, resulting in strange formatting #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! My apologies for the late review. I think that we can safely remove |
…spaces, resulting in strange formatting
|
@topecongiro no problem and thanks for having a look! I have removed the |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1210
The proposed implementation of
rewrite_stringrelies less on manual handling of ranges within the string, which I find (subjectively!) easier to reason about. If you prefer the previous logic, I will modify this PR accordingly.In addition, this rewrite keeps the
max_widthargument although it is unused ATM, for reasons described in a comment of the issue. I will change this PR as per the comment's response.