Accept manifest path option #3023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2018 00:55
The `getopts::Matches` struct has a `free` field containing all the args not matched by the opts parser. Using this is much more reliable than manually parsing the args a second time and getting false positives.
|
Yes! This would be nice to have.
Some tests for this would be nice, although they're tricky to make nice - ideally we wouldn't have lots of dummy projects as test data. |
Convert `#![doc]` and `#[doc]` attributes to `//!` and `///` doc comments.
when `normalize_doc_attributes` is off, they shouldn't be normalized to a doc comment
when `normalize_doc_attributes` is on, they shouldn't be affected
The other shapes of doc attributes shouldn't be normalized or modified.
The leading whitespace of a multine string was taken into account when computing the `min_prefix_space_width`, even if that line couldn't be trimmed. The consequence is it was always shifting the macro's content to the right.
|
Aborting all of this and restarting in another branch because I'm awful at git rebasing. Thanks for the direction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Kind of a rust newbie here and I think I may have bitten off more than I can chew. I'm looking to solve #2817 and I'm struggling. I'd like to get
cargo fmt --manifest-pathworking likecargo run --manifest-pathbut I'm not sure how to mesh it with the other strategies:CargoFmtStrategy::Root,CargoFmtStrategy::All, andCargoFmtStrategy::Some.I guess what I'm stuck on is trying to understand the reasoning behind how those strategies work. There aren't any tests to reference so it's hard to dig up the reasons behind them, like what kind of project setups they're meant to be used with. I'd be happy to write up some tests for this once I can wrap my head around it. I think understanding that would help me add a new strategy.
Thoughts? Is this something you'd like to see in the project?
Thanks for your time and the awesome project!