Skip to content

fix Erasing inner attributes in struct #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019

Conversation

rchaser53
Copy link
Contributor

fix #3592

Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm!

src/patterns.rs Outdated
@@ -226,7 +226,8 @@ fn rewrite_struct_pat(
}
}

let fields_str = wrap_struct_field(context, &fields_str, shape, v_shape, one_line_width);
// ast::Pat doesn't attrs so use &[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ast::Pat doesn't attrs so use &[]
// ast::Pat doesn't have attrs so use &[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I forgot to type it. Thank you.

@topecongiro topecongiro merged commit fbd9f33 into rust-lang:master May 29, 2019
@topecongiro
Copy link
Contributor

Thank you!

@rchaser53 rchaser53 deleted the issue-3592 branch May 29, 2019 23:31
@topecongiro topecongiro added this to the 1.3.0 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erasing inner attributes in blocks
3 participants